Shortcodes private #18559
Merged
Shortcodes private #18559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…codes. Imported samples and ran dev-tool for sample creation.
…rc subfolder. Previous commit from Erica fixed root issue.
…rther polishing of readme probably needed
…tions. Pending on a possible swagger mistake, that's why it is not building.
…codes. Imported samples and ran dev-tool for sample creation.
…rc subfolder. Previous commit from Erica fixed root issue.
…rther polishing of readme probably needed
…tions. Pending on a possible swagger mistake, that's why it is not building.
…ces, renaming variables, updating changelog
…azure-sdk-for-js into shortcodes-private
AlonsoMondal
requested review from
benbp,
bterlson,
deyaaeldeen,
jeremymeng,
mikeharder,
praveenkuttappan,
ramya-rao-a,
witemple-msft and
xirzec
as code owners
ericasp16
approved these changes
Nov 5, 2021
mikeharder
approved these changes
Nov 5, 2021
sadasant
pushed a commit
to sadasant/azure-sdk-for-js
that referenced
this pull request
Nov 6, 2021
* added autorest readme and generated files * rush.json modified and rush update-build ran for communication-short-codes. Imported samples and ran dev-tool for sample creation. * copied commincation-phone-numbers .gitignore into communication-short-codes * added README.md for short codes * fix @azure-tools reference * removed temporary fix for dist-esm and types files not generated in src subfolder. Previous commit from Erica fixed root issue. * modified sample to new changes (removed signup and fixed useCase) * changed createUSProgramBrief to upserUSProgramBrief in README.md - further polishing of readme probably needed * fixed wrong references to short codes package imports in readme.md * regenerated from latest swagger * regenerated from swagger from now merged PR. Added necessary modifications. Pending on a possible swagger mistake, that's why it is not building. * updated swagger, updated sdk, referencing latest commit in master for swagger. * built samples * Added compiling tests with meat but it is VERY RAW. Like the animal is still alive. * added autorest readme and generated files * rush.json modified and rush update-build ran for communication-short-codes. Imported samples and ran dev-tool for sample creation. * copied commincation-phone-numbers .gitignore into communication-short-codes * added README.md for short codes * fix @azure-tools reference * removed temporary fix for dist-esm and types files not generated in src subfolder. Previous commit from Erica fixed root issue. * modified sample to new changes (removed signup and fixed useCase) * changed createUSProgramBrief to upserUSProgramBrief in README.md - further polishing of readme probably needed * fixed wrong references to short codes package imports in readme.md * regenerated from latest swagger * regenerated from swagger from now merged PR. Added necessary modifications. Pending on a possible swagger mistake, that's why it is not building. * updated swagger, updated sdk, referencing latest commit in master for swagger. * built samples * Added compiling tests with meat but it is VERY RAW. Like the animal is still alive. * meat ready to cook * Regenerated with autorest from latest changes. Swagger now points to Rodolfo * updated sample from swagger * unit tests running and passing. unit tests with AAD failing. * updating tests to get env variables and splitting upsert in update & create * removed AAD tests * removed non-existing links to public documentation in sample readmes * added pnpm-lock.yml for short codes and removed unnecessary imports because of removed AAD tests. * reverted accidental change * added short codes to communication ci.yml * wrapping calls to the generated client in try catch finally blocks. automatic formatting * refactoring us program brief for better accessing and not to repeat data * changing let that should be const and unnecessary id check on test USPB retrieval. * grabbed pnpm-lock.yaml from azure/main and used rush update * missing pnpm-lock.yaml changes * fixing lint issues and building * run rushx format * fixes for recorded tests * running rushx format * added changelog * ran prepare release script * resolving comments from PR. Deleting unused variables, fixing references, renaming variables, updating changelog * run the format command * Update ci.yml * Update ci.yml * trying change from rest to tools * updating samples * added missing pnpm-lock.yaml update * updating release date Co-authored-by: Erica Sponsler <[email protected]> Co-authored-by: 0rlanand0Wats0n <[email protected]>
danieljurek
pushed a commit
that referenced
this pull request
Nov 10, 2021
* added autorest readme and generated files * rush.json modified and rush update-build ran for communication-short-codes. Imported samples and ran dev-tool for sample creation. * copied commincation-phone-numbers .gitignore into communication-short-codes * added README.md for short codes * fix @azure-tools reference * removed temporary fix for dist-esm and types files not generated in src subfolder. Previous commit from Erica fixed root issue. * modified sample to new changes (removed signup and fixed useCase) * changed createUSProgramBrief to upserUSProgramBrief in README.md - further polishing of readme probably needed * fixed wrong references to short codes package imports in readme.md * regenerated from latest swagger * regenerated from swagger from now merged PR. Added necessary modifications. Pending on a possible swagger mistake, that's why it is not building. * updated swagger, updated sdk, referencing latest commit in master for swagger. * built samples * Added compiling tests with meat but it is VERY RAW. Like the animal is still alive. * added autorest readme and generated files * rush.json modified and rush update-build ran for communication-short-codes. Imported samples and ran dev-tool for sample creation. * copied commincation-phone-numbers .gitignore into communication-short-codes * added README.md for short codes * fix @azure-tools reference * removed temporary fix for dist-esm and types files not generated in src subfolder. Previous commit from Erica fixed root issue. * modified sample to new changes (removed signup and fixed useCase) * changed createUSProgramBrief to upserUSProgramBrief in README.md - further polishing of readme probably needed * fixed wrong references to short codes package imports in readme.md * regenerated from latest swagger * regenerated from swagger from now merged PR. Added necessary modifications. Pending on a possible swagger mistake, that's why it is not building. * updated swagger, updated sdk, referencing latest commit in master for swagger. * built samples * Added compiling tests with meat but it is VERY RAW. Like the animal is still alive. * meat ready to cook * Regenerated with autorest from latest changes. Swagger now points to Rodolfo * updated sample from swagger * unit tests running and passing. unit tests with AAD failing. * updating tests to get env variables and splitting upsert in update & create * removed AAD tests * removed non-existing links to public documentation in sample readmes * added pnpm-lock.yml for short codes and removed unnecessary imports because of removed AAD tests. * reverted accidental change * added short codes to communication ci.yml * wrapping calls to the generated client in try catch finally blocks. automatic formatting * refactoring us program brief for better accessing and not to repeat data * changing let that should be const and unnecessary id check on test USPB retrieval. * grabbed pnpm-lock.yaml from azure/main and used rush update * missing pnpm-lock.yaml changes * fixing lint issues and building * run rushx format * fixes for recorded tests * running rushx format * added changelog * ran prepare release script * resolving comments from PR. Deleting unused variables, fixing references, renaming variables, updating changelog * run the format command * Update ci.yml * Update ci.yml * trying change from rest to tools * updating samples * added missing pnpm-lock.yaml update * updating release date Co-authored-by: Erica Sponsler <[email protected]> Co-authored-by: 0rlanand0Wats0n <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating release date for release